[lworld] RFR: 8372686: [lworld] runtime/cds/serviceability/ReplaceCriticalClasses.java fails with --enable-preview

Ioi Lam iklam at openjdk.org
Thu Dec 18 17:12:01 UTC 2025


On Thu, 18 Dec 2025 13:11:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This replaces Locale with Calendar and removes BaseLocale to test loading with ClassFileLoadHook, like my previous pull request.  Also removes the test from the ProblemList-enable-valhalla.txt file.
> 
> BaseLocale is also loaded and I thought it was the migrated classes that caused early loading for Locale, but it was really the module patching that we used to do for --enable-preview.  See call stack in bug report.
> 
> Tested with the test on windows, where it failed.

LGTM.

-------------

Marked as reviewed by iklam (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1827#pullrequestreview-3594021883


More information about the valhalla-dev mailing list