[lworld] RFR: 8362252: [lworld] Possible synchronization issue in jdk/internal/jimage/ImageReader.java
Roger Riggs
rriggs at openjdk.org
Thu Dec 18 21:16:51 UTC 2025
On Thu, 18 Dec 2025 13:36:12 GMT, David Beaumont <duke at openjdk.org> wrote:
> Tidying up syncrhonization around shared image.
src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 416:
> 414: OPEN_FILES.put(key, sharedReader);
> 415: } else if (sharedReader.getByteOrder() != byteOrder) {
> 416: throw new IOException("\"" + sharedReader.getName() + "\" is not an image file");
Its pre-existing, but ...
Testing the byteOrder and then throwing an exception that says it is not an Image file doesn't make sense.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1828#discussion_r2632646830
More information about the valhalla-dev
mailing list