[lworld] RFR: 8373987: [lworld] exploded-image/test broken since disable patching (JDK-8373806)
David Beaumont
duke at openjdk.org
Mon Dec 22 18:52:33 UTC 2025
On Mon, 22 Dec 2025 14:43:41 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:
> LGTM.
>
> One nit at line #735 in classLoader.cpp, the convention within the file is to specify the variable that you are checking nullptr against first, if (preview_entry != nullptr)...
>
> Thanks, Lois
I was just following what I saw code around doing (I don't know if you'd catch "(x = nullptr)" and assumed the reversed/"yoda" style was a guard against that.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1854#issuecomment-3683603422
More information about the valhalla-dev
mailing list