[lworld+fp16] RFR: 8345053: Add support for FP16 valueOf routines [v2]

[Bhavana Kilambi]

On Mon, 3 Feb 2025 09:16:10 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add new microbenchmarks for valueOf() routines
>
> src/java.base/share/classes/java/lang/Float16.java line 391:
> 
>> 389: 
>> 390:     @IntrinsicCandidate
>> 391:     private static short longToFloat16(long value) {
> 
> Offlate there have been some concerns around keeping java side changes to a minimum,  doing boxing on the compiler side involves additional work, please refer to my changes on mainline
> https://github.com/openjdk/jdk/pull/22754/commits/692de9c03fb6344f9602617f0bed75c28c409ed0#diff-1929ace9ae6df116e2fa2a718ed3924d9dae9a2daea454ca9a78177c21477aa3R8641
> 
> But, for now, this looks ok, we can fine-tune going forward once we reach a stage of JDK mainline integration.

Got it, thank you!

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1332#discussion_r1939672291