[lworld] RFR: 8343846: [lworld] implement spec changes to stack map tables [v3]
Coleen Phillimore
coleenp at openjdk.org
Fri Feb 28 20:52:59 UTC 2025
On Fri, 28 Feb 2025 20:12:43 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> This patch implements the spec changes needed to realize the ACC_STRICT flag. See the JBS issue for more details.
>>
>> The patch is divided across 3 major commits:
>> 1. VM changes for asserting that strict fields are initialized before the super constructor is called
>> 2. Javac changes for generating the stack map table entries
>> 3. Test
>>
>> Verified with tier 1-3 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
>
> - Changed AssertUnsetFieldsTable to NameAndSig to bool
> - Coleen suggestions
This looks really good, and the design fits very nicely with the work of the verifier in verifying stackmap tables. I reviewed the Hotspot changes.
-------------
Marked as reviewed by coleenp (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1373#pullrequestreview-2651750832
More information about the valhalla-dev
mailing list