[lworld] RFR: 8347292: [lworld] oopDesc->print() is broken

[Coleen Phillimore]

On Wed, 8 Jan 2025 20:18:13 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Fix implementation of oopDesc->print():
>   - remove invalid assert
>   - fix printing for better readability
>   - fix offsets of nested fields
>   
> More details are available in the CR.

Looks good except I had one question.

src/hotspot/share/runtime/fieldDescriptor.cpp line 173:

> 171:         vk->do_nonstatic_fields(&print_field);
> 172:         if (this->field_flags().has_null_marker()) {
> 173:           for (int i = 0; i <  + 1; i++) st->print("  ");

Should this be indent + 1 ?

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1328#pullrequestreview-2540894933
PR Review Comment: https://git.openjdk.org/valhalla/pull/1328#discussion_r1909410802