[lworld] RFR: 8348607: [lworld] Calls to Unsafe.getValue() / Unsafe.putValue() must be updated [v2]

Chen Liang liach at openjdk.org
Wed Jan 29 22:28:02 UTC 2025


On Wed, 29 Jan 2025 21:11:16 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Core libraries counterpart of #1336.
>> 
>> This requires MemberName to fetch more information in initialization. A new int high flag field is added, in anticipation to a merger with the regular int flag field in the future. Currently, directly migrating the flags field to long is too impactful to the whole codebase.
>> 
>> Also 8348680 is addressed as well; it's some minor updates to make the null checks specific to references VH.
>> 
>> Testing: test/jdk/java/lang/invoke
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Completely trust the value stored in fields (checked by verifier)
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/vh-layout
>  - Fix TestIntrinsics, safety remarks
>  - Fix DMH too
>  - Remove redundant checks for missing locations
>  - New field in MemberName for now
>  - Adapt layouts stage 1 (need to store in MemberName)

Currently the TestIntrinsics fails on debug because the new getFlatValue/setFlagValue methods do not have intrinsics. Don't know if it's easier to comment out those tests or add new intrinsics.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1340#issuecomment-2623015702


More information about the valhalla-dev mailing list