[lworld] RFR: 8348607: [lworld] Calls to Unsafe.getValue() / Unsafe.putValue() must be updated [v2]

[Chen Liang]

On Thu, 30 Jan 2025 15:35:05 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Completely trust the value stored in fields (checked by verifier)
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/vh-layout
>>  - Fix TestIntrinsics, safety remarks
>>  - Fix DMH too
>>  - Remove redundant checks for missing locations
>>  - New field in MemberName for now
>>  - Adapt layouts stage 1 (need to store in MemberName)
>
> src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java line 118:
> 
>> 116:             } else {
>> 117:                 long offset = MethodHandleNatives.objectFieldOffset(member);
>> 118:                 int layout = member.isFlat() ? member.getLayout() : 0;
> 
> It would be cleaner to define layout == 0 as flat, so separate tests were not necessary.
> The layout field should always have a value.

Sure, currently `layout == 0` means non-flat (reference pointer). We can do that for MemberName and other things.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1340#discussion_r1936164679