[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v4]

[Coleen Phillimore]

On Thu, 3 Jul 2025 14:49:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> `RewriteBytecodesInlineTest` fails after # due to a new log message printing the pending exception name even though there may not be a pending exception:
>> `PENDING_EXCEPTION->klass()->name()->as_C_string()`
>> 
>> This patch refactors the loadable descriptor handling used in `SystemDictionary::load_shared_class` to better illustrate how the loadable descriptors property is handled and it corrects the log messages to be consistent with the messages used in the class file parser. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen comments

src/hotspot/share/classfile/classFileParser.cpp line 6189:

> 6187:           return; // Exception is still pending
> 6188:         }
> 6189:         assert(klass != nullptr, "Sanity check");

Can you call InstanceKlass::check_null_free_field from here too?

src/hotspot/share/oops/instanceKlass.cpp line 3594:

> 3592: }
> 3593: 
> 3594: void InstanceKlass::check_null_free_field(InstanceKlass* ik, TRAPS) {

Is ik not the same as 'this'?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2183355457
PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2183352357