[lworld] RFR: 8361496: [lworld] Treating interfaces as isValue() leads to failed assert

[Roger Riggs]

On Mon, 7 Jul 2025 22:44:42 GMT, Chen Liang <liach at openjdk.org> wrote:

> Reviewed a few sites of isValue() usages that cause immediate trouble with bootstrap and basic tests. Factor out `ValueClass::isValueObjectCompatible` and `isValueObjectInstance` to represent the two states of value classes: field types that can hold value objects, and field types that definitely hold value objects.
> 
> I think we still need a more throughout review for all `isValue` usages, such as those in MethodHandle or VarHandle. Preliminary testing hasn't revealed anything yet.
> 
> Testing: tier 1-3, seems to have no new failures

src/java.base/share/classes/java/lang/Class.java line 643:

> 641:             return false;
> 642:         }
> 643:         return !isIdentity();

Copy the lines from PR#1499.
Nothing is value unless preview is enabled.

Suggestion:

        return PreviewFeatures.isEnabled() ? !isIdentity() : false;

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1504#discussion_r2191371327