[lworld] RFR: 8361496: [lworld] Treating interfaces as isValue() leads to failed assert [v2]
Chen Liang
liach at openjdk.org
Tue Jul 8 14:34:50 UTC 2025
> Reviewed a few sites of isValue() usages that cause immediate trouble with bootstrap and basic tests. Factor out `ValueClass::isValueObjectCompatible` and `isValueObjectInstance` to represent the two states of value classes: field types that can hold value objects, and field types that definitely hold value objects.
>
> I think we still need a more throughout review for all `isValue` usages, such as those in MethodHandle or VarHandle. Preliminary testing hasn't revealed anything yet.
>
> Testing: tier 1-3, seems to have no new failures
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Test both preview and non-preview for ValueClassTest
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1504/files
- new: https://git.openjdk.org/valhalla/pull/1504/files/d9d4668f..425ad16d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1504&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1504&range=00-01
Stats: 14 lines in 2 files changed: 3 ins; 1 del; 10 mod
Patch: https://git.openjdk.org/valhalla/pull/1504.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1504/head:pull/1504
PR: https://git.openjdk.org/valhalla/pull/1504
More information about the valhalla-dev
mailing list