[lworld] RFR: 8361250: [lworld] use more IRNode regexes in valhalla IR tests [v2]

Marc Chevalier mchevalier at openjdk.org
Wed Jul 9 13:29:11 UTC 2025


> InlineTypeIRNode is Valhalla-specific and somewhat... antique. I've run into an issue where the old-timey regex for allocation didn't do the job. So, rather than reproducing the fix of [JDK-8314999](https://bugs.openjdk.org/browse/JDK-8314999) again, let's simply use `IRNode`'s regex for Valhalla as well.
> 
> The general idea: let's not define node regex specifically for Valhalla, but only for values. I've also introduced regexes for combinations we do all the time: for instance rather than having `ALLOC_OF, ANY_KLASS`, I made a `ALLOC_OF_ANY_KLASS`.
> 
> So what now:
> - `InlineTypeRegexes` => only value regexes.
> - `IRNode` => adapted to allow to define specialisation for `ALLOC_OF`, `ALLOC_ARRAY_OF`, `LOAD_OF_CLASS`, `STORE_OF_CLASS`, `STATIC_CALL_OF_METHOD` for specific classes/functions.
> - `InlineTypeIRNode` => define specialisations using the regexes defined in `InlineTypeRegexes`, nothing more!
> - `compiler/valhalla/inlinetypes/Test*` => use `IRNode` and `InlineTypeIRNode`.

Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:

  Address comments

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1503/files
  - new: https://git.openjdk.org/valhalla/pull/1503/files/90dfdf16..6dc2405e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1503&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1503&range=00-01

  Stats: 48 lines in 6 files changed: 13 ins; 20 del; 15 mod
  Patch: https://git.openjdk.org/valhalla/pull/1503.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1503/head:pull/1503

PR: https://git.openjdk.org/valhalla/pull/1503


More information about the valhalla-dev mailing list