[lworld] RFR: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV [v6]

[Coleen Phillimore]

On Mon, 7 Jul 2025 21:32:07 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> `RewriteBytecodesInlineTest` fails after # due to a new log message printing the pending exception name even though there may not be a pending exception:
>> `PENDING_EXCEPTION->klass()->name()->as_C_string()`
>> 
>> This patch refactors the loadable descriptor handling used in `SystemDictionary::load_shared_class` to better illustrate how the loadable descriptors property is handled and it corrects the log messages to be consistent with the messages used in the class file parser. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fred comments

I still have a couple of minor comments.

src/hotspot/share/classfile/classFileParser.cpp line 6175:

> 6173:                     err_msg("Class %s cannot have a null-free non-static field of its own type", _class_name->as_C_string()));
> 6174:         }
> 6175:         log_info(class, preload)("Preloading class %s during loading of class %s. \

I don't think the backslash is the right thing to do.  The C++ compiler will concatenate strings like "one " " two" so you should do that.

src/hotspot/share/oops/instanceKlass.cpp line 3594:

> 3592: }
> 3593: 
> 3594: void InstanceKlass::can_be_annotated_with_NullRestricted(InstanceKlass* type, Symbol* container_klass_name, TRAPS) {

The name "can_be" implies that it'll return a bool  Maybe a better name would be check_can_be_null_restricted(),

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1498#pullrequestreview-3002109108
PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2195377885
PR Review Comment: https://git.openjdk.org/valhalla/pull/1498#discussion_r2195395436