[lworld] RFR: 8361496: [lworld] Treating interfaces as isValue() leads to failed assert [v2]
Chen Liang
liach at openjdk.org
Mon Jul 14 21:17:51 UTC 2025
On Mon, 14 Jul 2025 17:34:24 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Test both preview and non-preview for ValueClassTest
>
> test/jdk/valhalla/valuetypes/ValueClassTest.java line 60:
>
>> 58: assertFalse(isValueObjectCompatible(ArrayList[].class), "array class");
>> 59: assertFalse(isValueObjectCompatible(String[].class), "array class");
>> 60: assertFalse(isValueObjectCompatible(Comparable[].class), "array class");
>
> If these ever fail, the error messages are not going to be very information like`expected tru, actual = false Object`;
> no mention of preview mode being tested or the method under test.
Junit composes the exception message with the expected, actual values and the string provided, also there is the line number.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1504#discussion_r2205843902
More information about the valhalla-dev
mailing list