[lworld] RFR: 8361496: [lworld] Treating interfaces as isValue() leads to failed assert [v3]
Roger Riggs
rriggs at openjdk.org
Wed Jul 16 15:04:03 UTC 2025
On Tue, 15 Jul 2025 22:41:44 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Reviewed a few sites of isValue() usages that cause immediate trouble with bootstrap and basic tests. Factor out `ValueClass::isValueObjectCompatible` and `isValueObjectInstance` to represent the two states of value classes: field types that can hold value objects, and field types that definitely hold value objects.
>>
>> I think we still need a more throughout review for all `isValue` usages, such as those in MethodHandle or VarHandle. Preliminary testing hasn't revealed anything yet.
>>
>> Testing: tier 1-3, seems to have no new failures
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename, facelift test
Looks good thanks for the readability improvements.
-------------
Marked as reviewed by rriggs (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1504#pullrequestreview-3025459794
More information about the valhalla-dev
mailing list