[lworld] RFR: 8357785: [lworld] TestResolvedJavaType fails due to unexpected getInstanceFields order [v2]

[Marc Chevalier]

On Sun, 20 Jul 2025 07:40:44 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Quan Anh's comments
>
> src/hotspot/share/oops/fieldStreams.hpp line 325:
> 
>> 323:  * Doesn't traverse interfaces for now (let's decide how when/if the needs appear).
>> 324:  */
>> 325: template<typename FieldStreamType>
> 
> By "doesn't traverse interfaces for now" I assume this traverses both static and non-static fields. Tbh I think traversing static fields seems questionable, or maybe I miss some cases, maybe this stream can discard those, too?

I guess if we are not going through the interfaces, indeed, it wouldn't be reasonable to traverse half the static fields.

> test/hotspot/jtreg/ProblemList.txt line 135:
> 
>> 133: runtime/valhalla/inlinetypes/verifier/StrictInstanceFieldsTest.java CODETOOLS-7904031 generic-all
>> 134: runtime/valhalla/inlinetypes/verifier/StrictStaticFieldsTest.java CODETOOLS-7904031 generic-all
>> 135: runtime/cds/appcds/RewriteBytecodesInlineTest.java 8361082 generic-all
> 
> This issue is fixed with #1498 , so this seems like a merge conflict, right?

Exactly.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1511#discussion_r2221542613
PR Review Comment: https://git.openjdk.org/valhalla/pull/1511#discussion_r2221543892