[lworld] RFR: 8363846: [lworld] Make Class.isIdentityClass() non-native [v2]

[Roger Riggs]

On Wed, 23 Jul 2025 14:10:18 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a test for not enable preview.
>
> test/jdk/valhalla/valuetypes/IsIdentityClassTest.java line 68:
> 
>> 66:             assertFalse(ValueClass.isFlatArray(array0));
>> 67:         }
>> 68:         assertFalse(Integer.class.isIdentity(), "Integer is not an IDENTITY type");
> 
> This test should be sensitive to whether enable-preview is true.
> It should have failed in the second run. 
> But due to the TEST.properties (enablePreview = true) it overrides the command line in the test.
> Removing enablePreview in TEST.properties is the right fix for that but then another test needs a fix.
> The RecursiveValueClass test will need to have @enablePreview added to each of its test runs.

I'll fixup TEST.properties and the other test in a separate PR.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1514#discussion_r2225754960