[lworld] RFR: 8363846: [lworld] Make Class.isIdentityClass() non-native [v6]

Roger Riggs rriggs at openjdk.org
Wed Jul 23 20:17:04 UTC 2025


On Wed, 23 Jul 2025 19:23:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This moves isIdentityClass() implementation to Class.java, and checks within the JVM that is_identity_class() doesn't check the access flags for an ArrayKlass, since AccessFlags aren't initialized in ArrayKlasses.  The AccessFlags should be moved from Klass.hpp to InstanceKlass.cpp in mainline but that's a more complicated change and has several pieces.
>> Added a test.
>> Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the test to test both --enable-preview and not.

The test looks good, the conditions are more complicated than is obvious because with --enable-preview new modifier bits are defined with new used.
Thanks for the updates.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1514#pullrequestreview-3048874227


More information about the valhalla-dev mailing list