[lworld] RFR: 8357785: [lworld] TestResolvedJavaType fails due to unexpected getInstanceFields order [v3]

[Marc Chevalier]

On Fri, 25 Jul 2025 08:21:24 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Second round of comments
>
> src/hotspot/share/code/nmethod.cpp line 3846:
> 
>> 3844:       if (!did_name)
>> 3845:         stream->print("%s", type2name(t));
>> 3846:       // If the entry has a non-default sort_offset, it must be a null marker
> 
> Comment needs to be updated.

I think it can just be removed: if it's a null marker, we print that it's a null marker. I think we don't need it.

> src/hotspot/share/runtime/sharedRuntime.cpp line 2869:
> 
>> 2867:             if (bt == T_OBJECT) {
>> 2868:               // Nullable inline type argument, insert InlineTypeNode::NullMarker field right after T_METADATA delimiter
>> 2869:               // Set the sort_offset so that the field is detected as null marker by nmethod::print_nmethod_labels.
> 
> This comment needs to be updated. It still mentions the `sort_offset`.

I think we can do without the second line. The first says we include a null marker, and the second gives true to the null_marker parameter. Pretty straightforward.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1511#discussion_r2230642917
PR Review Comment: https://git.openjdk.org/valhalla/pull/1511#discussion_r2230645885