[lworld] RFR: 8339481: [lworld] C2: Rename InlineTypeNode::IsInit to NotNull

[Tobias Hartmann]

On Mon, 23 Jun 2025 12:42:06 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

> Picked the proposed name I found the most fitting. Added a comment to address the concern in the issue.

Thanks for working on this, Marc!

There are some more places that need re-naming, for example: Getter/setter methods, `ObjectValue::_is_init`, code in `PhaseOutput::FillLocArray`, code in `Deoptimization::realloc_objects`, code in `StackValue::create_stack_value`. Also, all the occurrences of `is_init` in inlinetypenode.hpp/cpp.

src/hotspot/share/opto/inlinetypenode.hpp line 111:

> 109:   Node* get_oop() const    { return in(Oop); }
> 110:   void  set_oop(PhaseGVN& gvn, Node* oop) { set_req_X(Oop, oop, &gvn); }
> 111:   Node* get_is_init() const { return in(NullMarker); }

The method names need a re-naming as well.

-------------

Changes requested by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1491#pullrequestreview-2953432330
PR Review Comment: https://git.openjdk.org/valhalla/pull/1491#discussion_r2163734572