[lworld] RFR: 8339481: [lworld] C2: Rename InlineTypeNode::IsInit to NotNull [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Jun 25 10:47:42 UTC 2025


On Tue, 24 Jun 2025 16:08:58 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Picked the proposed name I found the most fitting. Added a comment to address the concern in the issue.
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More rename

Thanks Marc. The additional changes look good but I found some more places that need adjustment. Search for `IsInit`, all occurrences need to be adjusted. I think they can simply be replaced by `null marker`.

src/hotspot/share/opto/inlinetypenode.hpp line 51:

> 49:          Oop,        // Oop to heap allocated buffer.
> 50:          IsBuffered, // True if inline type is heap allocated (or nullptr), false otherwise.
> 51:          NullMarker, // Needs to be checked for nullptr before using the field values.

Suggestion:

         NullMarker, // Needs to be checked before using the field values.

-------------

Changes requested by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1491#pullrequestreview-2956890512
PR Review Comment: https://git.openjdk.org/valhalla/pull/1491#discussion_r2165951948


More information about the valhalla-dev mailing list