[lworld] RFR: 8351441: [lworld] ClassFile API support generating stack maps for strict field assignment [v6]

[Vicente Romero]

On Tue, 11 Mar 2025 19:50:38 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Works for a basic case, running tests, need more tests to ensure other features added in this patch
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into feature/cf-strict
>  - Fix flow merge checks
>  - wip loop work
>  - Move test to classfile
>  - Should check array mismatch instead of just frames (can have backward jumps)
>  - Years
>  - Add a cache for strict field check
>  - Fix field transformation that add strict flag
>  - Further optimize impl, complete tests
>  - 8351441: [lworld] ClassFile API support generating stack maps for strict field assignment

Marked as reviewed by vromero (Committer).

test/jdk/jdk/classfile/StrictStackMapsTest.java line 119:

> 117:     }
> 118: 
> 119:     @Test

nit: it would be great if a comment with the corresponding java code being generated was included in these tests, this will make easier future changes, fixing bugs etc. But I let that to your consideration

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1392#pullrequestreview-2676259165
PR Review Comment: https://git.openjdk.org/valhalla/pull/1392#discussion_r1990212993