[lworld] RFR: 8351979: Improve verification error messages for strict fields
Coleen Phillimore
coleenp at openjdk.org
Fri Mar 14 18:35:21 UTC 2025
On Fri, 14 Mar 2025 17:05:17 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Placing a ResourceMark here messes with the error message so I opted not to use one.
>
> Regarding stringStream, there's a chance that approach would flood the log output in some cases. Although most realistic cases would have a few strict instance fields per class, it is still possible to have a large amount and create a massive error message that could be hard to trace.
>
> I think a minimal but descriptive error message is sufficient here and then users can use `-Xlog:verification` for the complete list of fields.
Okay, that makes sense. Also ResourceMarks are tricky in this code since so much is resource allocated.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1400#discussion_r1996043896
More information about the valhalla-dev
mailing list