[lworld] RFR: 8351362: Post-process @Strict annotation for testing [v3]
Roger Riggs
rriggs at openjdk.org
Tue Mar 18 20:15:17 UTC 2025
On Tue, 18 Mar 2025 20:05:46 GMT, Chen Liang <liach at openjdk.org> wrote:
>> test/lib/jdk/test/lib/value/Strict.java line 1:
>>
>>> 1: /*
>>
>> Can we use import `jdk.internal.vm.annotation.Strict` and not introduce a duplicate annotation?
>> This code is already `using jdk.internal.vm.annotation.NullRestricted`.
>>
>> And/or add a comment here indicating it is an intentional duplication.
>
> @dansmithcode aims to migrate all usages of the internal strict to this test-specific strict. This is actually the reason behind this PR - annotations in the Java Language must not change program semantics.
That would then apply to NullRestricted also?
That seems like an unnecessary split, since Strict is an internal annotation, it doesn't matter whether it is declared in a test specific library or jdk.internal.value. and it make maintenance harder because they are split.
And it makes prototyping uses of Strict more difficult.
And not defined or specified anywhere.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1395#discussion_r2001909724
More information about the valhalla-dev
mailing list