[lworld] RFR: 8351569: [lworld] Revisit atomic access modes in flat var handles [v7]

Chen Liang liach at openjdk.org
Fri Mar 21 17:53:19 UTC 2025


On Fri, 21 Mar 2025 16:21:10 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR is an attempt to put var handle support for flat values on a more solid footing. Some more notes in a comment below.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing `@ForceInline`

src/java.base/share/classes/java/lang/invoke/X-VarHandle.java.template line 441:

> 439: #end[Object]
> 440: #if[FlatValue]
> 441:         final int layout;        

extra spaces

test/jdk/valhalla/valuetypes/NullRestrictedArraysTest.java line 29:

> 27:  * @enablePreview
> 28:  * @run junit/othervm NullRestrictedArraysTest
> 29:  * @run junit/othervm -XX:-UseArrayFlattening NullRestrictedArraysTest

Why remove the no flattening configurations?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1402#discussion_r2008048497
PR Review Comment: https://git.openjdk.org/valhalla/pull/1402#discussion_r2008053379


More information about the valhalla-dev mailing list