[lworld] RFR: 8351569: [lworld] Revisit atomic access modes in flat var handles [v5]

Chen Liang liach at openjdk.org
Fri Mar 21 17:53:20 UTC 2025


On Fri, 21 Mar 2025 16:13:58 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/misc/Unsafe.java line 3286:
>> 
>>> 3284:     }
>>> 3285: 
>>> 3286:     public Object getAndSetFlatValue(Object o, long offset, int layoutKind, Class<?> valueType, Object newValue) {
>> 
>> Why no more `@ForceInline`?
>
> Good catch

Still missing forceinline here
Suggestion:

    @ForceInline
    public Object getAndSetFlatValue(Object o, long offset, int layoutKind, Class<?> valueType, Object newValue) {

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1402#discussion_r2008052152


More information about the valhalla-dev mailing list