[lworld] RFR: 8351569: [lworld] Revisit atomic access modes in flat var handles [v8]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Mar 21 19:02:31 UTC 2025


On Fri, 21 Mar 2025 18:56:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> test/jdk/valhalla/valuetypes/NullRestrictedArraysTest.java line 29:
>> 
>>> 27:  * @enablePreview
>>> 28:  * @run junit/othervm NullRestrictedArraysTest
>>> 29:  * @run junit/othervm -XX:-UseArrayFlattening NullRestrictedArraysTest
>> 
>> Why remove the no flattening configurations?
>
> If array flattening is disabled, but field flattening is enabled, we might run into situation where the new flat array primitive fails -- that primitive requires same level of flattening for both arrays and fields.

I've now re-enabled this combo -- but disabled both array flattening and nullable flattening.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1402#discussion_r2008165367


More information about the valhalla-dev mailing list