[lworld] RFR: 8350632: [lworld] Parse::array_store_check() assert introduced by 8348411 fails

Tobias Hartmann thartmann at openjdk.org
Wed Mar 26 13:20:38 UTC 2025


On Wed, 26 Mar 2025 11:37:13 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The assert introduced with JDK-8348411 is too strong when having value classes around because of the following reason:
> 
> https://github.com/openjdk/valhalla/blob/3f6f249bd457538f020d062ffe5b295509b45a4c/src/hotspot/share/opto/parseHelper.cpp#L265-L267
> 
> I've updated the assert to make it work with value classes by special casing them.
> 
> Thanks,
> Christian

Looks good to me. Thanks for working on this, Christian!

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1410#pullrequestreview-2717141466


More information about the valhalla-dev mailing list