[lworld] RFR: 8334484: [lworld] new translation strategy for instance field initializers [v3]

[Vicente Romero]

On Mon, 31 Mar 2025 13:23:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> It seems like there's few more cleanup opportunities now that we detect "early" strict field instance reads in `Resolve` (which make things a lot simpler).
> 
> Note: a possible different implementation tactic could be to add some info to JCIdent/JCFieldAccess, so that we can record that the accessed field was instance strict, and that access was "early" (or, we could create a special variable symbol to communicate this). This would eliminate the need for a map. And would also be a bit more precise when rewriting -- because we can only rewrite field accesses that have the special tree/symbol -- and leave the other in place.

not sure what would be the benefit of rewriting some accesses and some not, also there could be two sources of truth for a given field

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LocalProxyVarsGen.java line 245:
> 
>> 243:         @Override
>> 244:         public void visitIdent(JCTree.JCIdent tree) {
>> 245:             if (fieldToLocalMap.get(tree.sym) != null) {
> 
> How do we tell this not to rewrite a field access if there's no need (e.g. not in early context) ?

yep that's a problem, I thought about fixing this but then I forgot, good catch!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1403#issuecomment-2766848021
PR Review Comment: https://git.openjdk.org/valhalla/pull/1403#discussion_r2021417088