[lworld] RFR: 8352068: [lworld] test StrictFinalInstanceFieldsTest.java needs to be updated after fix for JDK-8351951 [v2]

[Coleen Phillimore]

On Thu, 8 May 2025 17:41:25 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Updates to javac prevent it from creating classes with improper uses of strict fields. Additionally, non-final strict fields are now allowed so `StrictFinalInstanceFieldsTest.java` needs to updated with new test cases. This patch adds new cases for final and non-final stricts as well as negative test cases using asmtools that check improper use of strict fields and early larval stack map frames. 
>> 
>> During testing, it was revealed that the new verify errors added in [JDK-8354694](https://bugs.openjdk.org/browse/JDK-8354694) do not work properly so a fix is included in this patch.
>> 
>> Note: This cannot be integrated until jtreg is updated with a recent build of asmtools which can handle strict fields and can generate early_larval frames.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Problem list test until jtreg is updated

test/hotspot/jtreg/ProblemList.txt line 142:

> 140: runtime/valhalla/inlinetypes/PreloadCircularityTest.java 8349631 linux-aarch64-debug
> 141: runtime/valhalla/inlinetypes/ValuePreloadTest.java 8349630 linux-aarch64-debug
> 142: runtime/valhalla/inlinetypes/verifier/StrictInstanceFieldsTest.java generic-all

Does this require a bug number?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1449#discussion_r2080186619