[lworld] RFR: 8335256: [lworld] C2: Remove larval InlineTypeNode [v5]

Quan Anh Mai qamai at openjdk.org
Fri May 9 18:10:05 UTC 2025


On Fri, 9 May 2025 09:37:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - move progress check
>>  - Merge branch 'lworld' into larvaloop
>>  - fast path for non intrinsics
>>  - fix test failures
>>  - Merge branch 'lworld' into larvaloop
>>  - remove larval InlineTypeNode
>
> src/hotspot/share/opto/macro.cpp line 2907:
> 
>> 2905:   while (C->macro_count() > 0) {
>> 2906:     if (iteration++ > 100) {
>> 2907:       assert(false, "Too slow convergence of macro elimination");
> 
> Is this something that should be upstreamed to mainline?

I think this mostly helps if we try to eliminate allocations without or before EA (because otherwise allocations should be scalarized at safepoints during EA already). As a result, it is necessary only if this is also done:

>  // Eliminate some macro nodes before EA to reduce analysis pressure

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1447#discussion_r2082246572


More information about the valhalla-dev mailing list