[lworld] RFR: 8356963: [lworld] MemNode::optimize_simple_memory_chain fails with "sanity check for basic cases" [v2]

Tobias Hartmann thartmann at openjdk.org
Fri May 16 13:05:05 UTC 2025


On Thu, 15 May 2025 16:48:30 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Many thanks to @TobiHartmann for the speedy investigation. This patch fixes the issue by adding a `ciField` for the null marker. I also do a small change to make the name of the `ciField` of a flattened field clearer. I think adding a scenario to test flattening of nullable and atomic fields is necessary. There are some failures that I filed https://bugs.openjdk.org/browse/JDK-8357061 for the investigation.
>> 
>> Please kindly review, thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include

I also noticed that `try_optimize_strict_final_load_memory` has a `field` argument that is unused.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1456#issuecomment-2886664346


More information about the valhalla-dev mailing list