[lworld] RFR: 8356963: [lworld] MemNode::optimize_simple_memory_chain fails with "sanity check for basic cases" [v4]
duke
duke at openjdk.org
Tue May 20 07:02:03 UTC 2025
On Sun, 18 May 2025 07:08:43 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Many thanks to @TobiHartmann for the speedy investigation. This patch fixes the issue by adding a `ciField` for the null marker. I also do a small change to make the name of the `ciField` of a flattened field clearer. I think adding a scenario to test flattening of nullable and atomic fields is necessary. There are some failures that I filed https://bugs.openjdk.org/browse/JDK-8357061 for the investigation.
>>
>> Please kindly review, thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>
> fix SigEntry comparison
@merykitty
Your change (at version c7194bf3ecd4c4969838276365dfa8d606b7737c) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1456#issuecomment-2893187473
More information about the valhalla-dev
mailing list