[lworld] RFR: 8352068: [lworld] test StrictFinalInstanceFieldsTest.java needs to be updated after fix for JDK-8351951 [v4]

[Matias Saavedra Silva]

On Thu, 22 May 2025 18:28:34 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'lworld' into new_strict_tests_8352068
>>  - Added bug number to problem listed test
>>  - Problem list test until jtreg is updated
>>  - Remove old test
>>  - Added copyright
>>  - Added more positive test cases
>>  - [lworld] test StrictFinalInstanceFieldsTest.java needs to be updated after fix for JDK-8351951
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/verifier/StrictFieldsNotSubset.jcod line 161:
> 
>> 159:             Attr(#36) {                    // StackMapTable
>> 160:               [] {                         //
>> 161:                 246b, []{#8; #12}, {            // early_larval_frame
> 
> Is the issue here?  That #12 is not a strict field?  A comment of the form `// ERROR: #12 doesn't name a strict field` would go a long way to making this understandable in the future

The issue is that there is a field, or rather a NameAndType, that doesn't exist in the initial set of strict fields. The early_larval frame offers a set of fields that are not a subset of the initial set of strict fields generated in the VM. This is certainly one of the larger and more confusing tests so I'll add comments to this test as well as the others.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1449#discussion_r2105377799