[lworld] RFR: 8357474: [lworld] Consolidate load/store flat inline types [v8]

Tobias Hartmann thartmann at openjdk.org
Mon May 26 12:58:13 UTC 2025


On Mon, 26 May 2025 09:11:05 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   weird layout
>
> src/hotspot/share/opto/inlinetypenode.cpp line 716:
> 
>> 714:   kit->C->set_flat_accesses();
>> 715:   ciInlineKlass* vk = inline_klass();
>> 716:   assert(vk->maybe_flat_in_array(), "");
> 
> Please add an assert message

Same for the other asserts with `..., "");`

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1470#discussion_r2107038915


More information about the valhalla-dev mailing list