[lworld] RFR: 8357474: [lworld] Consolidate load/store flat inline types [v9]

[Quan Anh Mai]

On Mon, 26 May 2025 09:09:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'lworld' into loadstoreflat
>>  - cast_to_flat_array
>>  - weird layout
>>  - typo
>>  - generalize weird layout
>>  - fix array of nullable empty type
>>  - fix array field calculations
>>  - array
>>  - convert_from_payload
>>  - add tests
>>  - ... and 1 more: https://git.openjdk.org/valhalla/compare/d1759c70...e49bbc8c
>
> src/hotspot/share/opto/inlinetypenode.cpp line 488:
> 
>> 486:       if (base->is_Con() && oop_ptr->is_inlinetypeptr() && !is_array && !mismatched) {
>> 487:         // If the oop to the inline type is constant (static final field), we can
>> 488:         // also treat the fields as constants because the inline type is immutable.
> 
> Why is this not needed anymore?

Because the loads we generate can be constant-folded, there is no need for an explicit path here.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1470#discussion_r2107554051