[lworld] RFR: 8352068: [lworld] test StrictFinalInstanceFieldsTest.java needs to be updated after fix for JDK-8351951 [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Thu May 29 19:04:45 UTC 2025
> Updates to javac prevent it from creating classes with improper uses of strict fields. Additionally, non-final strict fields are now allowed so `StrictFinalInstanceFieldsTest.java` needs to updated with new test cases. This patch adds new cases for final and non-final stricts as well as negative test cases using asmtools that check improper use of strict fields and early larval stack map frames.
>
> During testing, it was revealed that the new verify errors added in [JDK-8354694](https://bugs.openjdk.org/browse/JDK-8354694) do not work properly so a fix is included in this patch.
>
> Note: This cannot be integrated until jtreg is updated with a recent build of asmtools which can handle strict fields and can generate early_larval frames.
Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
- Merge branch 'lworld' into new_strict_tests_8352068
- Dan comment, new test case, and test refactor
- Merge branch 'lworld' into new_strict_tests_8352068
- Added bug number to problem listed test
- Problem list test until jtreg is updated
- Remove old test
- Added copyright
- Added more positive test cases
- [lworld] test StrictFinalInstanceFieldsTest.java needs to be updated after fix for JDK-8351951
-------------
Changes: https://git.openjdk.org/valhalla/pull/1449/files
Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=1449&range=04
Stats: 1808 lines in 11 files changed: 1546 ins; 262 del; 0 mod
Patch: https://git.openjdk.org/valhalla/pull/1449.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1449/head:pull/1449
PR: https://git.openjdk.org/valhalla/pull/1449
More information about the valhalla-dev
mailing list