[lworld] RFR: 8368467: [lworld] Add new flag generation for jimage to support preview mode [v2]
David Beaumont
duke at openjdk.org
Wed Nov 5 15:21:00 UTC 2025
On Tue, 4 Nov 2025 21:02:22 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor feedback changes
>
> src/java.base/share/classes/jdk/internal/jimage/PreviewMode.java line 95:
>
>> 93: // will be always 'true' and this code, and all related dead-code can be removed.
>> 94: private static final boolean DISABLE_PREVIEW_PATCHING_DEFAULT = false;
>> 95: private static final boolean ENABLE_PREVIEW_MODE = Boolean.parseBoolean(
>
> the naming is confusing: stick to the same sense as the system property; (Or change the system property)
Done. New snapshot uploaded.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1718#discussion_r2495021061
More information about the valhalla-dev
mailing list