[lworld] RFR: 8341771: [lworld] Heap dump recognizing new flat fields formats [v2]

[Alex Menkov]

On Wed, 5 Nov 2025 20:28:16 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed T_FLAT_ELEMENT in StackRefDumper
>
> src/hotspot/share/services/heapDumper.cpp line 1818:
> 
>> 1816: void JavaStackRefDumper::dump_java_stack_refs(StackValueCollection* values) {
>> 1817:   for (int index = 0; index < values->size(); index++) {
>> 1818:     // TODO: can it be T_FLAT_ELEMENT?
> 
> The BasicType T_FLAT_ELEMENT is used exclusively in the context of flat arrays: in the layout_helper of flat arrays, and in a few array methods like arrayOopDesc::base_offset_in_bytes().
> T_FLAT_ELEMENT cannot be used to describe the type of a field, the type of the argument of a Java method or the type of a value on the stack.

Thank you, removed

> test/lib/jdk/test/lib/hprof/model/JavaObject.java line 324:
> 
>> 322: 
>> 323:                 }
>> 324:         } catch (IOException exp) {
> 
> The indentation of the catch block seems off.

This is revert of the previous implementation (first 2 commits)
With new approach hprof format is not changed, so I restored hprof test lib as it is in mainline

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1700#discussion_r2496305454
PR Review Comment: https://git.openjdk.org/valhalla/pull/1700#discussion_r2496311310