RFR: 8368475: [lworld] Add preview classes to jimage at make time [v4]

David Beaumont duke at openjdk.org
Fri Nov 7 13:21:08 UTC 2025


> Copies valuetype classes for each module into corresponding "/META-INF/preview/..." sub-directories to be pulled into jimage files and processed by the new preview mode handling code.
> 
> There might be a better way to do this in terms of Makefile semantics, but this seems to work well enough and doesn't prevent the value-class JAR files being generated for patching (which is still how everyone will get value classes until the rest of the work is plumbed in).
> 
> To enable the new preview mode work, set the "DISABLE_PREVIEW_PATCHING" system property to "true".

David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:

 - Copy value classes into preview directories for inclusion in jimage
 - Rename ModuleReference methods back.
 - [[AUTOMATIC FORMATTING]]
 - fixing jlink issue
 - Feedback and test fix
 - Minor feedback changes
 - [[AUTOMATIC FORMATTING]]
 - fixing tests after refactoring
 - Fixing up after dependent PR changes
 - feedback and remove unused code
 - ... and 6 more: https://git.openjdk.org/valhalla/compare/3b7c8cc3...4fda33ae

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1719/files
  - new: https://git.openjdk.org/valhalla/pull/1719/files/3b7c8cc3..4fda33ae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1719&range=03
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1719&range=02-03

  Stats: 1622 lines in 35 files changed: 273 ins; 386 del; 963 mod
  Patch: https://git.openjdk.org/valhalla/pull/1719.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1719/head:pull/1719

PR: https://git.openjdk.org/valhalla/pull/1719


More information about the valhalla-dev mailing list