RFR: 8368475: [lworld] Add preview classes to jimage at make time [v3]

David Beaumont duke at openjdk.org
Fri Nov 7 13:24:30 UTC 2025


On Thu, 6 Nov 2025 22:51:06 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> David Beaumont has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Rollup of makefile changes and jlink fix (temp).
>>   
>>   * likely test fix
>>   * Copy value classes into preview directories for inclusion in jimage
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line 305:
> 
>> 303: 
>> 304:         /**
>> 305:          *  line: {@code <int>|<int>|<hashOrTarget>|<path>}
> 
> For internal doc/methods, javadoc markup makes the source harder to read.

The I'll either make it a `///` markup comment or a plain `/*` block comment.
Making `/**` comment blocks and then putting invalid HTML in is making it harder (sometimes impossible) to be read in an IDE.
If this comment is only about people reading it in source code, it should never have been a "JavaDoc" comment.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1719#discussion_r2503512252


More information about the valhalla-dev mailing list