[lworld] RFR: 8371429: [lworld] Fix package name inference for ResourcePoolManager for preview mode
Roger Riggs
rriggs at openjdk.org
Wed Nov 12 14:48:45 UTC 2025
On Thu, 6 Nov 2025 20:45:10 GMT, David Beaumont <duke at openjdk.org> wrote:
> Switches package inference to handle preview resource paths.
>
> Additionally:
> * Updates unit test to use JUnit.
> * Deletes unused code (both newly unused and previously unused).
Looks good.
test/jdk/tools/jlink/ResourcePoolTest.java line 1:
> 1: /*
Update copyright please.
test/jdk/tools/jlink/ResourcePoolTest.java line 232:
> 230: assertTrue(resources.findEntry(res.path()).isPresent(), "Resource not found: " + res);
> 231: assertTrue(modules.contains(res.moduleName()), "Module not found: " + res.moduleName());
> 232: assertTrue(modules.contains(res.moduleName()), "Module not found: " + res.moduleName());
Duplicate assert.
-------------
PR Review: https://git.openjdk.org/valhalla/pull/1724#pullrequestreview-3453815212
PR Review Comment: https://git.openjdk.org/valhalla/pull/1724#discussion_r2518600513
PR Review Comment: https://git.openjdk.org/valhalla/pull/1724#discussion_r2518590170
More information about the valhalla-dev
mailing list