[lworld] RFR: [lworld] Switch JLink to not use ImageReader API [v8]

David Beaumont duke at openjdk.org
Wed Nov 12 14:58:39 UTC 2025


On Fri, 7 Nov 2025 15:48:35 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comment adjustment
>
> test/jdk/tools/jlink/runtimeImage/PackagedModulesVsRuntimeImageLinkTest.java line 57:
> 
>> 55:  * @build tests.* jdk.test.lib.process.OutputAnalyzer
>> 56:  *        jdk.test.lib.process.ProcessTools
>> 57:  * @run main/othervm/timeout=1200 -ea -esa -DDISABLE_PREVIEW_PATCHING=false -Xmx1g PackagedModulesVsRuntimeImageLinkTest
> 
> Should this test (temporarily) be run both with and without the new packaging?

Until the makefile stuff is in, it won't work because there are no preview classes in the image and disabling patching will just mean there's no preview stuff at all.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1721#discussion_r2518638166


More information about the valhalla-dev mailing list