[lworld] RFR: 8371292: [lworld] Switch JLink to not use ImageReader API [v10]
Roger Riggs
rriggs at openjdk.org
Wed Nov 12 18:36:10 UTC 2025
On Wed, 12 Nov 2025 17:44:18 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Creates a new, narrowed API explicitly for use by jlink, which view the resource entries in a jimage file without the re-mapping of names and invention of synthetic entries inherent in ImageReader.
>>
>> Another good reason to express this new API as something other than ImageReader is that, to fix issues such as [JDK-8357249](https://bugs.openjdk.org/browse/JDK-8357249), we don't want to have the (System)ImageReader class used directly in jlink code. It's just the wrong abstraction and will make it harder to refactor jlink to use a non-singleton API with a controlled lifetime later.
>>
>> I've not added unit tests for the new API (yet), but the fact the PackagedModulesVsRuntimeImageLinkTest passes with preview content in the jimage file means that it's working as expected.
>
> David Beaumont has updated the pull request incrementally with two additional commits since the last revision:
>
> - Copyright fix
> - Copyright fix
Marked as reviewed by rriggs (Committer).
-------------
PR Review: https://git.openjdk.org/valhalla/pull/1721#pullrequestreview-3454901418
More information about the valhalla-dev
mailing list