[lworld] RFR: 8371915: [lworld] LayoutKind enum should have helper methods

Dan Heidinga heidinga at openjdk.org
Wed Nov 19 21:48:34 UTC 2025


On Tue, 18 Nov 2025 18:19:00 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Add some helper methods to test properties of layouts in a more reliable way.
> 
> Tested with Mach5, tier 1 to 3.
> 
> Fred

src/hotspot/share/oops/arrayKlass.cpp line 231:

> 229:     break;
> 230:     case LayoutKind::NULLABLE_ATOMIC_FLAT:
> 231:       props = ArrayKlass::ArrayProperties::NON_ATOMIC;

Why does NULLABLE_ATOMIC_FLAT produce NON_ATOMIC?  Something, maybe just naming?, seems off here.

I know this is a refactoring of existing code and so has the same meaning but it doesn't make sense to me

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1745#discussion_r2543646279


More information about the valhalla-dev mailing list