[lworld] RFR: 8371915: [lworld] LayoutKind enum should have helper methods [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Nov 24 18:21:09 UTC 2025
On Mon, 24 Nov 2025 13:58:38 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> It might not be a good idea based on all the places that we read the LayoutKind enum values, in which case, never mind.
>
> I've tried to refactor as suggested, encapsulating the enum inside a class, but it makes a lot of code much more cumbersome than it already is when testing for a particular layout. I'd propose to push this refactoring as it is right now, and engage in some brainstorming to try to find a way to make this whole layout concept more natural in the code.
That sounds fine to me. Thanks for considering it.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1745#discussion_r2557276543
More information about the valhalla-dev
mailing list