[lworld] RFR: 8367242: [lworld] C2 compilation asserts with "dead loop detected" [v2]
Marc Chevalier
mchevalier at openjdk.org
Wed Oct 1 09:35:39 UTC 2025
On Wed, 1 Oct 2025 05:46:50 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Set phis input to top initially, not merge with top.
>
> src/hotspot/share/opto/inlinetypenode.cpp line 57:
>
>> 55: PhiNode* oop;
>> 56: if (phi_input_are_top) {
>> 57: oop = PhiNode::make(region, top, t);
>
> For readability, I would prefer:
>
> `oop = PhiNode::make(region, phi_input_are_top ? top : vt->get_oop(), t)`
I guess that's a matter of taste... Done.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1640#discussion_r2393984851
More information about the valhalla-dev
mailing list