[lworld] Integrated: 8367767: [lworld] Interpreter adherence to new memory model rules for strict instance fields

[Frederic Parain]

On Tue, 30 Sep 2025 19:40:07 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Create new method entry for the interpreter to add a memory barrier when entering the j.l.Object constructor.
>
> src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 1:
> 
>> 1: /*
> 
> Can you add a comment mentioning StoreStore at the equivalent place in this method?  It'll make it easier to find where the barrier is expected / compare across platforms.  I always trip on the fact that the x86 `_return` implementation doesn't mention anything

Done

> src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp line 1142:
> 
>> 1140: // Generic interpreted method entry to (asm) interpreter
>> 1141: //
>> 1142: address TemplateInterpreterGenerator::generate_normal_entry(bool synchronized, bool object_init) {
> 
> Same request about a comment here

Add the barrier here, because I think the platform needs it.

> src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp line 1242:
> 
>> 1240: // Generic interpreted method entry to (asm) interpreter
>> 1241: //
>> 1242: address TemplateInterpreterGenerator::generate_normal_entry(bool synchronized, bool object_init) {
> 
> Same request for a comment so there's breadcrumbs to find

Done.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1647#discussion_r2394753688
PR Review Comment: https://git.openjdk.org/valhalla/pull/1647#discussion_r2394756075
PR Review Comment: https://git.openjdk.org/valhalla/pull/1647#discussion_r2394757131