[lworld] RFR: 8368939: [lworld] TestInliningProtectionDomain fails since jdk-26+11 [v2]

Damon Fenacci dfenacci at openjdk.org
Thu Oct 2 14:52:46 UTC 2025


> ## Issue
> `compiler/ciReplay/TestInliningProtectionDomain.java` for class `ProtectionDomainTestNoOtherCompilationPrivate` fails because it expects `bar()` not to be inlined but it gets inlined instead.
> 
> ## Cause
> `TestInliningProtectionDomain` checks that ciReplay inlining does not fail with unresolved signature classes. For class `ProtectionDomainTestNoOtherCompilationPrivate` it expects `Integer` in its signature to be unresolved but it is resolved instead. The reason for this is that in valhalla boxing classes are automatically added when registering a loader ([JDK-8364034](https://bugs.openjdk.org/browse/JDK-8364034) (and later [JDK-8364483](https://bugs.openjdk.org/browse/JDK-8364483)):
> https://github.com/openjdk/valhalla/blob/708b4f92431df90c115dac840fb8194ec3aac3fe/src/hotspot/share/classfile/systemDictionary.cpp#L215-L217
> 
> ## Fix
> `TestInliningProtectionDomain` should actually use a different class than `Integer` (a class that is not in the migrated value classes set, like `java.lang.Thread`. Changed in all classes for "consistency").
> 
> ## Testing
> Tier 1-3

Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:

  JDK-8368939: fixed comment

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1651/files
  - new: https://git.openjdk.org/valhalla/pull/1651/files/3fed0ea2..51858f4c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1651&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1651&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/valhalla/pull/1651.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1651/head:pull/1651

PR: https://git.openjdk.org/valhalla/pull/1651


More information about the valhalla-dev mailing list