[lworld] RFR: 8368939: [lworld] TestInliningProtectionDomain fails since jdk-26+11 [v2]
duke
duke at openjdk.org
Fri Oct 3 06:57:54 UTC 2025
On Thu, 2 Oct 2025 14:52:46 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> ## Issue
>> `compiler/ciReplay/TestInliningProtectionDomain.java` for class `ProtectionDomainTestNoOtherCompilationPrivate` fails because it expects `bar()` not to be inlined but it gets inlined instead.
>>
>> ## Cause
>> `TestInliningProtectionDomain` checks that ciReplay inlining does not fail with unresolved signature classes. For class `ProtectionDomainTestNoOtherCompilationPrivate` it expects `Integer` in its signature to be unresolved but it is resolved instead. The reason for this is that in valhalla boxing classes are automatically added when registering a loader ([JDK-8364034](https://bugs.openjdk.org/browse/JDK-8364034) (and later [JDK-8364483](https://bugs.openjdk.org/browse/JDK-8364483)):
>> https://github.com/openjdk/valhalla/blob/708b4f92431df90c115dac840fb8194ec3aac3fe/src/hotspot/share/classfile/systemDictionary.cpp#L215-L217
>>
>> ## Fix
>> `TestInliningProtectionDomain` should actually use a different class than `Integer` (a class that is not in the migrated value classes set, like `java.lang.Thread`. Changed in all classes for "consistency").
>>
>> ## Testing
>> Tier 1-3
>
> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8368939: fixed comment
@dafedafe
Your change (at version 74b8af65387ba0fd96969dbe51eb12a90c26044f) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1651#issuecomment-3364492732
More information about the valhalla-dev
mailing list